Overflow

[Rosko]

I've just mashed together a vbscript, lifted from that 'Sword Sample' script (Im not very proficient at scripting). I can't work out what I've done wrong, because after about 10 seconds, an overflow error is displayed, then it say's "Error playing map: Display must be open to flip".

Also, the player sprite doesnt change over to the one I specified in the script when button 1 is depressed.

Help me somebody!!

[durnurd]

Well, uploading the script may help, so we can tell you more specifically what the problem is.  Also, if a sprite is not deleted when it leaves the map and keeps traveling off the map too far, you will get this error.  Or, if you have a variable that continuously increases every frame, it will eventually overflow, but that's more unlikely than the first.

In any case, upload the script and try running your project without the script and see if you have the same error.

[Rosko]

The error still happened without the script. I set the three separate sprite definitions of the player sprite to auto-delete when off map, and this fixed the errors. I still have the problem with my player sprite not changing when button one is pressed.

So, here is the script so far.

***********modified 28/07/05*****************

Code: [Select]

Dim nExpectCount      'number of sprites to expect in
Dim nShot0Count         'number of sword sprites
Dim arBtn0Shots(0)      'sword sprites

Dim nButton0State

'generated by wizard
'watches for button/key press by player
Sub Player_OnControllerMove(OldActions, NewActions)
   If (Not OldActions) And NewActions And ACTION_BUTTON1 Then nButton0State = 1
   If (Not NewActions) And ACTION_BUTTON1 Then nButton0State = 0
End Sub

'generated by wizard
'apprears to remove references to sprites that are not on screen/in existence
Sub RecountShots()
   Dim nSIdx, nLIdx
   With ProjectObj.GamePlayer.PlayerSprite.rDef.rLayer
      nSIdx = 0
      Do While nSIdx < nShot0Count
         For nLIdx = 0 to .SpriteCount - 1
            If arBtn0Shots(nSIdx) Is .Sprite(nLIdx) Then
               Exit For
            End If
         Next
         If nLIdx >= .SpriteCount Then
            Set arBtn0Shots(nSIdx) = arBtn0Shots(nShot0Count - 1)
            nShot0Count = nShot0Count - 1
         Else
            nSIdx = nSIdx + 1
         End If
      Loop

      nExpectCount = .SpriteCount
   End With
End Sub

'generated by wizard
'removes a sprite from the layer/screen
Sub RemoveShot(Spr)
   Dim nIdx
   With ProjectObj.GamePlayer.PlayerSprite.rDef.rLayer
      For nIdx = 0 to .SpriteCount - 1
         If .Sprite(nIdx) Is Spr Then .RemoveSprite(nIdx) : Exit Sub
      Next
   End With
End Sub



'originally generated by wizard; modified/debugged by Mark
'returns the appropriate "velocity" for a magic attack based on PlayerSprite's state
Function GetStateDeltas(DX, DY)
   With ProjectObj.GamePlayer.PlayerSprite
      Select Case .rDef.Template.StateType
      Case STATE_SINGLE
         If Abs(DX) + Abs(DY) > 1 Then
            DX = .DX / Abs(.DX) + Abs(.DY)
            DY = .DY / Abs(.DX) + Abs(.DY)
         Else
            If Abs(DX) + Abs(DY) < 1 Then DX = 0 : DY = -1
         End If
      Case STATE_LEFT_RIGHT
         DY = 0
         If (.CurState mod 2) = 0 Then DX = -1 Else DX = 1
      Case STATE_8_DIRECTION
         Select Case (.CurState mod 8)
         Case 0 : DX = 0 : DY = -1
         Case 1 : DX = 1 : DY = -1
         Case 2 : DX = 1 : DY = 0
         Case 3 : DX = 1 : DY = 1
         Case 4 : DX = 0 : DY = 1
         Case 5 : DX = -1 : DY = 1
         Case 6 : DX = -1 : DY = 0
         Case 7 : DX = -1 : DY = -1
         End Select
      Case Else
         DX = Cos((.CurState mod 36) * 3.14159 / 18)
         DY = -Sin((.CurState mod 36) * 3.14159 / 18)
      End Select
   End With
End Function



'orginally generated by wizard; modified by Mark
'deals with particularities of each sprite before each frame is drawn, see internal documentation for more information
Sub Player_OnAfterMoveSprites
   'setup some values for screen
   Dim nIdx, VLeft, VTop, VRight, VBottom, VDat
   With ProjectObj.GamePlayer
      VLeft = .MapScrollX
      VTop = .MapScrollY
      VRight = VLeft + .rMap.ViewWidth
      VBottom = VTop + .rMap.ViewHeight
   End With

   If nButton0State > 0 Then DoFireButton0

     
   If nExpectCount <> ProjectObj.GamePlayer.PlayerSprite.rDef.rLayer.SpriteCount Then RecountShots
   'if player is attacking with sword
      if nShot0Count = 1 then
      'check if the last frame of the sword is being displayed, if true, remove sword sprite, change player sprite to non-attacking sprite
      Dim o

If arBtn0Shots(0).CurFrame >= 6 Then  
         RemoveShot arBtn0Shots(0)
         nShot0Count = 0
         nExpectCount = nExpectCount - 1
         SwitchPlayerSprite "BoxyPlayer"
         'Set ProjectObj.GamePlayer.PlayerSprite.rDef.Template = ProjectObj.GamePlayer.rMap.SpriteTemplates("Player")
      'if false, fix direction (state) of sword sprite with respect to player sprite
      'and move the sword sprite to appropriate location based on player sprite location
      else      
         GetStateDeltas DX, DY
         With ProjectObj.GamePlayer.PlayerSprite
            arBtn0Shots(0).CurState = (.CurState Mod 2)
               
            If DX = 0 Then
               arBtn0Shots(0).X = .X + (.Width - arBtn0Shots(0).Width) / 2
            ElseIf DX = -1 Then
               arBtn0Shots(0).X = .X - .Width
            ElseIf DX = 1 Then
               arBtn0Shots(0).X = .X + .Width
            End If    

            If DY = 1 AND DX = 0 Then
               arBtn0Shots(0).Y = .Y + .Height
            ElseIf DY = 0 Then
               arBtn0Shots(0).Y = .Y + (.Height - arBtn0Shots(0).Height) / 2
            ElseIf DY = -1 AND DX = 0 Then
               arBtn0Shots(0).Y = .Y - .Height
            else
               arBtn0Shots(0).Y = .Y + (.Height - arBtn0Shots(0).Height) / 2
            End If
         end with    

      end if
   end if

   'manually advance animation frame of sword (due to an error in 1.2.3 -- motion/animate speed integrated)
   'NOTE: unnecessary looping involved: to be modified
   Dim nAnimIdx
   For nAnimIdx = 0 to nShot0Count - 1
      arBtn0Shots(nAnimIdx).AdvanceFrame 1
   Next

End Sub





'originally generated by wizard; heavily modified by Mark
'deals with attacking with sword, see internal documentation
Sub DoFireButton0()
   Dim NewSpr, DX, DY

   nButton0State = nButton0State + 1
   If nButton0State < 20 And nButton0State > 2 Then Exit Sub Else nButton0State = 2


   'check for how many sword attacks there are on screen, if 1 or more, exit sub (so another sword attack will not be created)
   If nShot0Count >= 1 Then Exit Sub

   'create a sword sprite
   Set NewSpr = ProjectObj.GamePlayer.rMap.SpriteDefs("Sword").MakeInstance
   Set arBtn0Shots(nShot0Count) = NewSpr
   nShot0Count = 1
   With ProjectObj.GamePlayer.PlayerSprite
      .rDef.rLayer.AddSprite HostObj.AsObject(NewSpr)
      nExpectCount = nExpectCount + 1

      'set swords velocity to 0 (flying sword kind of odd in this case--though, this could be useful in a Zelda-esque charged sword situation)
      GetStateDeltas DX, DY
      NewSpr.DX = 0
      NewSpr.DY = 0

   'use DX and DY to determine the placement of sword sprite with respect to player sprite      
   If DX = 0 Then
      NewSpr.X = .X + (.Width - NewSpr.Width) / 2  'center sword horozontally
   ElseIf DX = -1 Then
      NewSpr.X = .X - .Width 'put sword on left
   ElseIf DX = 1 Then
      NewSpr.X = .X + .Width 'put sword on right
   End If

   If DY = 1 AND DX = 0 Then
      NewSpr.Y = .Y + .Height 'put sword on bottom
   ElseIf DY = 0 Then
      NewSpr.Y = .Y + (.Height - NewSpr.Height) / 2  'center sword vertically
   ElseIf DY = -1 AND DX = 0 Then
      NewSpr.Y = .Y - .Height 'put sword on top
   else
      NewSpr.Y = .Y + (.Height - NewSpr.Height) / 2  'center sword vertically
   End If

   if ProjectObj.GamePlayer.PlayerSprite.CurState > 7 then
         arBtn0Shots(0).CurState = ProjectObj.GamePlayer.PlayerSprite.CurState - 8
   else
      arBtn0Shots(0).CurState = ProjectObj.GamePlayer.PlayerSprite.CurState
   end if

   'change the player sprite to an attacking sprite
   SwitchPlayerSprite "BoxyJab"

   End With
End Sub




'generated by Wizard
'appears to change from X & Y velocities to "polar" state (36 state)
Function RectToPolarState(X, Y)
   Dim Angle, Pi
   Pi = 3.14159
   If X <> 0 Then
       Angle = Atn(-Y / X)
   Else
       Angle = -(Pi / 2) * Sgn(Y)
   End If
   If X < 0 Then
       Angle = Pi + Angle
   ElseIf Y > 0 Then
       Angle = Pi * 2 + Angle
   End If
   RectToPolarState = ((Angle * 18) / Pi) Mod 36
End Function




'catches special functions from map, both are called by collision definitions
'the "Kill" special function is used to add 1 to kill inventory item
'the "Die" special frunction is used to remove 5 HP from player, and then at 0 HP display a "game over" screen
Sub Player_OnSpecialFunction(SpecialFunction)
   If SpecialFunction.Name = "Kill" then
      ProjectObj.GamePlayer.InvQuantityOwned(1) = ProjectObj.GamePlayer.InvQuantityOwned(1) + 1
   end if
   if SpecialFunction.Name = "Die" then
      ProjectObj.GamePlayer.InvQuantityOwned(0) = ProjectObj.GamePlayer.InvQuantityOwned(0) - 5
      If ProjectObj.GamePlayer.InvQuantityOwned(0) = 0 then
         ProjectObj.GamePlayer.ActivateFunction ProjectObj.Maps("City").Specials("Game Over")
         ProjectObj.GamePlayer.bQuit = True
      End If
   End If
   
End Sub





'switches player sprite from one sprite to another based on the name of the new sprite
Sub SwitchPlayerSprite(NewSpriteName)
       Dim NewSpr
       Dim Idx
       Dim MyState
       MyState = ProjectObj.GamePlayer.PlayerSprite.CurState
       With ProjectObj.GamePlayer.PlayerSprite.rDef.rLayer
             Set NewSpr = .pMap.SpriteDefs(NewSpriteName).MakeInstance
             .AddSprite(NewSpr)
             NewSpr.X = ProjectObj.GamePlayer.PlayerSprite.X
             NewSpr.Y = ProjectObj.GamePlayer.PlayerSprite.Y
             For Idx = 0 to .SpriteCount - 1
                   If .Sprite(Idx) Is ProjectObj.GamePlayer.PlayerSprite Then
                         .RemoveSprite Idx
                         Exit For
                   End If
             Next
             Set ProjectObj.GamePlayer.PlayerSprite = NewSpr
       End With
       ProjectObj.GamePlayer.PlayerSprite.CurState = MyState        
End Sub




'required code to work (attaches script to project at runtime)
HostObj.SinkObjectEvents ProjectObj.GamePlayer, "Player"
HostObj.ConnectEventsNow()
ProjectObj.GamePlayer.Play 16

[bluemonkmn]

If you use "BoxyPlayer" in the SinkObjectEvents call, then you need to replace all functions that start with "Player_" to "BoxyPlayer_" (like BoxyPlayer_OnAfterMoveSprites).  I suggest putting that back to "Player" since that's only used to determine the name of all the event handler functions for the object you are connecting.  It has nothing to do with your project/sprites.

[Rosko]

opss! Changed it back to player, I wasn't sure about that in the beginning.
When button one is pressed, it comes up with "Error Playing Map: Subscript out of range", then "Script stopped at line 105 on character 3: Subscript out of range"

**above script modified**

[bluemonkmn]

Can you determine what's on line 105?  When I look at line 105 in the script above, it doesn't have anything at character 3 so I'm suspecting maybe yours is spaced out differently than mine.

[Rosko]

Here is the code on line 105 exactly!

Code: [Select]

     If arBtn0Shots(0).CurFrame = arBtn0Shots(0).rDef.StateFrameCount(arBtn0Shots(0).CurState) - 1 then

When I tried testing it today, it says character 7 now....I must have made a typo in the post above!

Are spaces included? I'm assuming so, then that would mean it's pointing directly at the "If", that starts the line.

[bluemonkmn]

I think the next thing is to narrow it down more by seeing which piece of the line really has the problem -- try accessing individual expressions on the line by assigning them to variables and see where the error happens (put this code right before the place where the error happens):

Code: [Select]


Dim o
Set o = arBtn0Shots(0)
Dim i
i = o.CurFrame
i = o.CurState
Set o = o.rDef
i = o.StateFrameCount(i)
o.CurFrame = i-1


[Anonymous]

Did this and reports error on new code!

'Line 111 character 1'

Code: [Select]

i = o.StateFrameCount(i)

Was this a predicted error?

[bluemonkmn]

I think that means that the sprite is in an invalid state so it has an error trying to retrieve the number of frames in that state.  But the only reason it needs to do that is so that it knows when to delete it.  It'd probably be easier to just hard-code the number of the last frame in your "sword" sprite or whatever you have.  So if your sword has 3 frames (0, 1 and 2) then do something like this instead of the If that was there causing the error before:

Code: [Select]

If arBtn0Shots(0).CurFrame >= 2 then

That will cause the sprite to get deleted when it gets to frame 2 without having to look up the info to see that frame 2 is the last frame.

[Rosko]

I've added this code the next error is back in the inserted code!

"Line 102, Character 1"

Code: [Select]

i = o.StateFrameCount(i)

The code at the beginning of the script has been updated.

[durnurd]

Well, you don't need that line anymore.  Hard-coding the sprite-frame count was the alternative for that.

[Rosko]

Error:
"Line 123, Character 16"

Code: [Select]

              arBtn0Shots(0).X = .X - .Width

I don't know if this helps, but now my original state "BoxyPlayer"(The walking state of my character), has stopped animating. Yet the spirit retains its normal motion left and right, with the first frame of both states.


Updated code above!!

[bluemonkmn]

What's the error?  When did your player stop animating?

[Rosko]

Actually, I think that's a whole other problem, because the animation freeze remains when I run the build without the script.

My main concern is getting the 'Sword' (linked sword stab animation) working with the 'BoxyJab' (player stab animation).