Adjusting Shooting Script

[quazi]

I'm trying to figure out how to adjust my basic shooting script created from the scripting wizard. So that when the sprite is created for the projectile, the direction is based on two inventory items (left/right) instead of sprite direction. I think I should use InvQuantityOwned, but not really sure to adjust the script so this works. Here's a copy of the basic shooting script for my level. Any help would be greatly appreciated.

Dim nExpectCount
Dim nShot0Count
Dim arBtn0Shots(2)
Sub Player_OnControllerMove(OldActions, NewActions)
   If (Not OldActions) And NewActions And ACTION_BUTTON1 Then DoFireButton0
End Sub

Sub RecountShots()
   Dim nSIdx, nLIdx
   With ProjectObj.GamePlayer.PlayerSprite.rDef.rLayer
      nSIdx = 0
      Do While nSIdx < nShot0Count
         For nLIdx = 0 to .SpriteCount - 1
            If arBtn0Shots(nSIdx) Is .Sprite(nLIdx) Then
               Exit For
            End If
         Next
         If nLIdx >= .SpriteCount Then
            Set arBtn0Shots(nSIdx) = arBtn0Shots(nShot0Count - 1)
            nShot0Count = nShot0Count - 1
         Else
            nSIdx = nSIdx + 1
         End If
      Loop

      nExpectCount = .SpriteCount
   End With
End Sub

Sub RemoveShot(Spr)
   Dim nIdx
   With ProjectObj.GamePlayer.PlayerSprite.rDef.rLayer
      For nIdx = 0 to .SpriteCount - 1
         If .Sprite(nIdx) Is Spr Then .RemoveSprite(nIdx) : Exit Sub
      Next
   End With
End Sub

Function GetStateDeltas(DX, DY)
   With ProjectObj.GamePlayer.PlayerSprite
      Select Case .rDef.Template.StateType
      Case STATE_SINGLE
         If Abs(DX) + Abs(DY) > 1 Then
            DX = .DX / (Abs(.DX) + Abs(.DY))
            DY = .DY / (Abs(.DX) + Abs(.DY))
         Else
            If Abs(DX) + Abs(DY) < 1 Then DX = 0 : DY = -1
         End If
      Case STATE_LEFT_RIGHT
         DY = 0
         If (.CurState Mod 2) = 0 Then DX = -1 Else DX = 1
      Case STATE_8_DIRECTION
         Select Case (.CurState Mod
         Case 0 : DX = 0 : DY = -1
         Case 1 : DX = 1 : DY = -1
         Case 2 : DX = 1 : DY = 0
         Case 3 : DX = 1 : DY = 1
         Case 4 : DX = 0 : DY = 1
         Case 5 : DX = -1 : DY = 1
         Case 6 : DX = -1 : DY = 0
         Case 7 : DX = -1 : DY = -1
         End Select
      Case Else
         DX = Cos((.CurState Mod 36) * 3.14159 / 18)
         DY = -Sin((.CurState Mod 36) * 3.14159 / 18)
      End Select
   End With
End Function

Sub Player_OnAfterMoveSprites
   Dim nIdx, VLeft, VTop, VRight, VBottom, VDat
   With ProjectObj.GamePlayer
      VLeft = .MapScrollX
      VTop = .MapScrollY
      VRight = VLeft + .rMap.ViewWidth
      VBottom = VTop + .rMap.ViewHeight
   End With

   If nExpectCount <> ProjectObj.GamePlayer.PlayerSprite.rDef.rLayer.SpriteCount Then RecountShots
   nIdx = 0
   Do While nIdx < nShot0Count
      With arBtn0Shots(nIdx)
         If .X < VLeft Or .X > VRight Or .Y < VTop Or .Y > VBottom Or (.DX = 0 And .DY = 0) Then
            RemoveShot arBtn0Shots(nIdx)
            Set arBtn0Shots(nIdx) = arBtn0Shots(nShot0Count - 1)
            nShot0Count = nShot0Count - 1
            nExpectCount = nExpectCount - 1
         Else
            nIdx = nIdx + 1
         End if
      End With
   Loop

End Sub

Sub DoFireButton0()
   Dim NewSpr, DX, DY
   If nShot0Count >= 3 Then Exit Sub
   If ProjectObj.GamePlayer.InvQuantityOwned(0) < 1 Then Exit sub
   ProjectObj.GamePlayer.InvQuantityOwned(0) = ProjectObj.GamePlayer.InvQuantityOwned(0) - 1
   Set NewSpr = ProjectObj.GamePlayer.rMap.SpriteDefs("RockThrow").MakeInstance
   Set arBtn0Shots(nShot0Count) = NewSpr
   nShot0Count = nShot0Count + 1
   With ProjectObj.GamePlayer.PlayerSprite
      .rDef.rLayer.AddSprite HostObj.AsObject(NewSpr)
      nExpectCount = nExpectCount + 1
      NewSpr.X = .X + (.Width - NewSpr.Width) / 2
      NewSpr.Y = .Y + (.Height - NewSpr.Height) / 2
   End With
End Sub

Function RectToPolarState(X, Y)
   Dim Angle, Pi
   Pi = 3.14159
   If X <> 0 Then
       Angle = Atn(-Y / X)
   Else
       Angle = -(Pi / 2) * Sgn(Y)
   End If
   If X < 0 Then
       Angle = Pi + Angle
   ElseIf Y > 0 Then
       Angle = Pi * 2 + Angle
   End If
   RectToPolarState = ((Angle * 18) / Pi) Mod 36
End Function

HostObj.SinkObjectEvents ProjectObj.GamePlayer, "Player"
HostObj.ConnectEventsNow()
ProjectObj.GamePlayer.Play 16

[durnurd]

What you need to do is change the DoFireButton0() sub to this:

Code: [Select]

Sub DoFireButton0()
   Dim NewSpr, DX, DY, InvItem, ShootLeft, ShootRight

   InvItem = 17
   ShootLeft = 0
   ShootRight = 1

   If nShot0Count >= 3 Then Exit Sub
   If ProjectObj.GamePlayer.InvQuantityOwned(0) < 1 Then Exit sub
   ProjectObj.GamePlayer.InvQuantityOwned(0) = ProjectObj.GamePlayer.InvQuantityOwned(0) - 1
   Set NewSpr = ProjectObj.GamePlayer.rMap.SpriteDefs("RockThrow").MakeInstance
   Set arBtn0Shots(nShot0Count) = NewSpr
   nShot0Count = nShot0Count + 1
   With ProjectObj.GamePlayer.PlayerSprite
      .rDef.rLayer.AddSprite HostObj.AsObject(NewSpr)
      nExpectCount = nExpectCount + 1
      NewSpr.X = .X + (.Width - NewSpr.Width) / 2
      NewSpr.Y = .Y + (.Height - NewSpr.Height) / 2
      If ProjectObj.GamePlayer.InvQuantityOwned(InvItem) = ShootLeft then
         NewSpr.DX = iif(NewSpr.DX < 0, NewSpr.DX, -NewSpr.DX) 'Shoot Left
      ElseIf ProjectObj.GamePlayer.InvQuantityOwned(InvItem) = ShootRight then
         NewSpr.DX = iif(NewSpr.DX > 0, NewSpr.DX, -NewSpr.DX) 'Shoot Right
      End If
   End With
End Sub

I've made this easily editable for you.  Where it says, at the top, "InvItem = 17" change the 17 to equal the number of the inventory item you are using to determine which way to fire the bullet.  Then, change the 0 in "ShootLeft = 0" to equal however many are in the inventory when you want to shoot left and vice versa for right.  This is assuming that the bullet already shoots out (has a velocity) when it is shot.  If not, then change the lines near the bottom that say "NewSpr.DX = ..." to "NewSpr.DX = -1" for shoot left and "NewSpr.DX = 1" for right

[Quazi]

First off thanks for the help Durnurd. But I've tried everything I can think of to make this script work. Without success... I set InvItem to 11, which is a new inventory item I made called Throw. It's the 11 of 14 in the player settings window of the editor.  This wont work with having ShootLeft = 1 and ShootRight = 0, so I changed that to ShootLeft = 1 and ShootRight = 2.. Using the ThrowRock sprite which has a vector path going to the right makes my player sprite shoot right and only right.  I tried using a left vector path and it would shoot to the left and only left.  I displayed the inventory item on the screen so I'm sure it's adding and subtracting correctly.  I'm thinking that if/then isn't telling the sprite to switch the direction of the vector but I'm not really sure what, iif(NewSpr.DX > 0, NewSpr.DX, -NewSpr.DX) does to change the DX. Also put in DX = -1 and DX = 0 but it still only shot one way and it barely moved away from my sprite like it had no inertia.

The script durnurd posted  wasn't origionally what I had in mind but it seems like it should work just as well.  My idea has 2 seperate items Left/Right.  I wanted to say

If ProjectObj.GamePlayer.InvQuantity(Left) = 1 then 'ShootLeft
Elseif ProjectObj.GamePlayer.InvQuantity(Right) = 1 then 'ShootRight

This didn't work either, I'm probably using the function incorretly.  Could I make an InvItemA and InvItemB variables so I can use multiple items in one Sub?  Or am I completely off track.

[Quazi]

Ok I figured it out.  This is what I did..
If ProjectObj.GamePlayer.InvQuantityOwned(10) = ShootLeft then
        NewSpr.DX = -1 * NewSpr.rDef.Template.MoveSpeed
      ElseIf ProjectObj.GamePlayer.InvQuantityOwned(10) = ShootRight then
         NewSpr.DX = 1 * NewSpr.rDef.Template.MoveSpeed
      End If
   End With

Seems I was wrong on the InvItem, guess it starts at 0 instead of 1.  Think it was this part of the code in the if/then that wasn't working right. NewSpr.DX = iif(NewSpr.DX < 0, NewSpr.DX, -NewSpr.DX) ... Once I got the inventory right I just added the -1/1 to the player speed and it worked. For future reference I'd still like to know how I'd call 2 different InvItems within the same Sub if anyone knows.

[durnurd]

Using a vector sprite makes the sprite go in that direction.  Have you taken a look at the "Shooting without scripting" example in the FAQ section?  Because it sounds like that may be what you are trying to do with the vector sprite.  But anyway, you may just want to use an inert sprite with the code you're using now.

[Quazi]

So I have the shooting part working correctly but I've ran into another problem. I've been going through lots of the post on the forums and looked at some games script code trying to figure this out.  I want to add script to the shooting script fromm earlier that changes the player sprite template .JumpHeight and MoveSpeed.. The effect I'm trying to achieve is after picking up an InvItem( "SpeedBoost" the jump and speed is doubled for a set amount of time that the 4 seperate sprites under the player sprite template..  I have a timer setup with InvItems and could either do this by checking the InvItem to change the movement or have a special function raise an event. So far I'm just trying to get my movement to change after picking up the item, but it doesn't seem to work.  I'm sure itsn't set up correctly since it doesn't work but here it is..  


Sub SpeedBoost()
   
   If ProjectObj.GamePlayer.rMap.name = "main" then

   With ProjectObj.GamePlayer
    If .InvQuantityOwned( = 1 then
     
   .rDef.Template.MoveSpeed = 10
        .rDef.Template.JumpHeight = 10
    End If
   End With
   End If
End Sub

[bluemonkmn]

If that code isn't causing errors, then I suspect the code isn't even getting called because there is no rDef property on the Player object itself.  You have to get the PlayerSprite object in order to get to the rDef property.  Try something like this:

Code: [Select]

Sub CheckBoost()
   With ProjectObj.GamePlayer
      If .InvQuantityOwned(8) = 1 Then
         With .PlayerSprite.rDef.Template
            .MoveSpeed = 10
            .JumpHeight = 10
         End With
      Else
         With .PlayerSprite.rDef.Template
            ' Revert to whatever's normal here
            .MoveSpeed = 6
            .JumpHeight = 6
         End With
      End If
   End With
End Sub

And then call CheckBoost at the beginning of Sub Player_OnAfterMoveSprites or something.

[Quazi]

Thanks Ben that works great!